chrome/browser/diagnostics/recon_diagnostics.cc - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: correct nits Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/diagnostics/recon_diagnostics.cc

diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc

index 390d2aa3d03688d5ac260257e61678861332fa50..9b8b537cb606cf6e32e7aa7ec3cb35c653a54af5 100644

--- a/chrome/browser/diagnostics/recon_diagnostics.cc

+++ b/chrome/browser/diagnostics/recon_diagnostics.cc

@@ -15,7 +15,6 @@

#include "base/sys_info.h"

#include "base/path_service.h"

#include "chrome/browser/diagnostics/diagnostics_test.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_version_info.h"

@@ -176,7 +175,8 @@ class VersionTest : public DiagnosticTest {

RecordFailure(ASCIIToUTF16("Empty Version"));

return true;

}

- std::string version_modifier = platform_util::GetVersionStringModifier();

+ std::string version_modifier =

+ chrome::VersionInfo::GetVersionStringModifier();

if (!version_modifier.empty())

current_version += " " + version_modifier;

#if defined(GOOGLE_CHROME_BUILD)

« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/mac/keystone_glue.mm » ('j') | no next file with comments »