chrome/browser/ui/gtk/about_chrome_dialog.cc - Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/about_chrome_dialog.cc

Issue 7249003: Move GetVersionStringModifier() and GetChannel() from platform_util_* to chrome_version_info_* (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: correct nits Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/about_chrome_dialog.cc

diff --git a/chrome/browser/ui/gtk/about_chrome_dialog.cc b/chrome/browser/ui/gtk/about_chrome_dialog.cc

index 400cce829beb62c933d48420cd700ec70b03388d..3c82649004ea0a01a9c36b2e13b40ef0ae268de8 100644

--- a/chrome/browser/ui/gtk/about_chrome_dialog.cc

+++ b/chrome/browser/ui/gtk/about_chrome_dialog.cc

@@ -11,7 +11,6 @@

#include "base/utf_string_conversions.h"

#include "chrome/browser/google/google_util.h"

-#include "chrome/browser/platform_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/gtk/cairo_cached_surface.h"

@@ -116,7 +115,7 @@ void ShowAboutDialogForProfile(GtkWindow* parent, Profile* profile) {

current_version += version_info.OSType();

current_version += ")";

#endif

- std::string channel = platform_util::GetVersionStringModifier();

+ std::string channel = chrome::VersionInfo::GetVersionStringModifier();

if (!channel.empty())

current_version += " " + channel;

« no previous file with comments | « chrome/browser/ui/cocoa/first_run_dialog.mm ('k') | chrome/browser/ui/views/about_chrome_view.cc » ('j') | no next file with comments »