Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 7058041: Remove ResourceDispatcherHost dependency on Chrome's LoginHandler and ExternalProtocolHandler. (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove ResourceDispatcherHost dependency on Chrome's LoginHandler and ExternalProtocolHandler. As part of this change, I've renamed the resource embedder interfaces from observer to delegates, since that's what they are now. I've also separated them into their own files and made both interfaces behave similarly in terms of ownership and treatment of filters. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87796

Patch Set 1 : '' #

Patch Set 2 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -430 lines) Patch
M chrome/browser/browser_process_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 4 chunks +26 lines, -18 lines 0 comments Download
A + chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 8 chunks +38 lines, -20 lines 0 comments Download
D chrome/browser/renderer_host/chrome_resource_dispatcher_host_observer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/renderer_host/chrome_resource_dispatcher_host_observer.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M content/browser/DEPS View 4 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.h View 4 chunks +7 lines, -53 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 12 chunks +29 lines, -32 lines 0 comments Download
A content/browser/renderer_host/resource_dispatcher_host_delegate.h View 1 chunk +91 lines, -0 lines 0 comments Download
A content/browser/renderer_host/resource_dispatcher_host_delegate.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A content/browser/renderer_host/resource_dispatcher_host_login_delegate.h View 1 chunk +26 lines, -0 lines 0 comments Download
A content/browser/renderer_host/resource_dispatcher_host_login_delegate.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.h View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/common/resource_dispatcher.h View 4 chunks +7 lines, -21 lines 0 comments Download
M content/common/resource_dispatcher.cc View 4 chunks +7 lines, -11 lines 0 comments Download
A content/common/resource_dispatcher_delegate.h View 1 chunk +29 lines, -0 lines 0 comments Download
A content/common/resource_dispatcher_delegate.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 6 months ago (2011-06-03 00:53:14 UTC) #1
Avi (use Gerrit)
9 years, 6 months ago (2011-06-03 01:45:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698