Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/ui/login/login_prompt.cc

Issue 7058041: Remove ResourceDispatcherHost dependency on Chrome's LoginHandler and ExternalProtocolHandler. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix deps Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/login/login_prompt.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/login/login_prompt.h" 5 #include "chrome/browser/ui/login/login_prompt.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
(...skipping 23 matching lines...) Expand all
34 34
35 // Helper to remove the ref from an net::URLRequest to the LoginHandler. 35 // Helper to remove the ref from an net::URLRequest to the LoginHandler.
36 // Should only be called from the IO thread, since it accesses an 36 // Should only be called from the IO thread, since it accesses an
37 // net::URLRequest. 37 // net::URLRequest.
38 void ResetLoginHandlerForRequest(net::URLRequest* request) { 38 void ResetLoginHandlerForRequest(net::URLRequest* request) {
39 ResourceDispatcherHostRequestInfo* info = 39 ResourceDispatcherHostRequestInfo* info =
40 ResourceDispatcherHost::InfoForRequest(request); 40 ResourceDispatcherHost::InfoForRequest(request);
41 if (!info) 41 if (!info)
42 return; 42 return;
43 43
44 info->set_login_handler(NULL); 44 info->set_login_delegate(NULL);
45 } 45 }
46 46
47 // Get the signon_realm under which this auth info should be stored. 47 // Get the signon_realm under which this auth info should be stored.
48 // 48 //
49 // The format of the signon_realm for proxy auth is: 49 // The format of the signon_realm for proxy auth is:
50 // proxy-host/auth-realm 50 // proxy-host/auth-realm
51 // The format of the signon_realm for server auth is: 51 // The format of the signon_realm for server auth is:
52 // url-scheme://url-host[:url-port]/auth-realm 52 // url-scheme://url-host[:url-port]/auth-realm
53 // 53 //
54 // Be careful when changing this function, since you could make existing 54 // Be careful when changing this function, since you could make existing
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 // Public API 479 // Public API
480 480
481 LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info, 481 LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info,
482 net::URLRequest* request) { 482 net::URLRequest* request) {
483 LoginHandler* handler = LoginHandler::Create(auth_info, request); 483 LoginHandler* handler = LoginHandler::Create(auth_info, request);
484 BrowserThread::PostTask( 484 BrowserThread::PostTask(
485 BrowserThread::UI, FROM_HERE, new LoginDialogTask( 485 BrowserThread::UI, FROM_HERE, new LoginDialogTask(
486 request->url(), auth_info, handler)); 486 request->url(), auth_info, handler));
487 return handler; 487 return handler;
488 } 488 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/login/login_prompt.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698