Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/login/login_prompt.h

Issue 7058041: Remove ResourceDispatcherHost dependency on Chrome's LoginHandler and ExternalProtocolHandler. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix deps Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.h
===================================================================
--- chrome/browser/ui/login/login_prompt.h (revision 87739)
+++ chrome/browser/ui/login/login_prompt.h (working copy)
@@ -9,9 +9,9 @@
#include <string>
#include "base/basictypes.h"
-#include "base/memory/ref_counted.h"
#include "base/synchronization/lock.h"
#include "chrome/browser/password_manager/password_manager.h"
+#include "content/browser/renderer_host/resource_dispatcher_host_login_delegate.h"
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
@@ -27,7 +27,7 @@
// This is the base implementation for the OS-specific classes that route
// authentication info to the net::URLRequest that needs it. These functions
// must be implemented in a thread safe manner.
-class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
+class LoginHandler : public ResourceDispatcherHostLoginDelegate,
public LoginModelObserver,
public NotificationObserver {
public:
@@ -39,6 +39,9 @@
static LoginHandler* Create(net::AuthChallengeInfo* auth_info,
net::URLRequest* request);
+ // ResourceDispatcherHostLoginDelegate implementation:
+ virtual void OnRequestCancelled();
+
// Initializes the underlying platform specific view.
virtual void BuildViewForPasswordManager(PasswordManager* manager,
const string16& explanation) = 0;
@@ -62,10 +65,6 @@
// This function can be called from either thread.
void CancelAuth();
- // Notify the handler that the request was cancelled.
- // This function can only be called from the IO thread.
- void OnRequestCancelled();
-
// Implements the NotificationObserver interface.
// Listens for AUTH_SUPPLIED and AUTH_CANCELLED notifications from other
// LoginHandlers so that this LoginHandler has the chance to dismiss itself
« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_observer.cc ('k') | chrome/browser/ui/login/login_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698