Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum. (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make Widget ownership a little clearer by expressing it in terms of an enum. BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86669

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -48 lines)			Patch
M	chrome/browser/chromeos/notifications/balloon_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/dropdown_bar_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/fullscreen_exit_bubble.cc	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/status_bubble_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/dragged_tab_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/focus/focus_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/view_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	views/widget/native_widget_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget_gtk.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	views/widget/native_widget_test_utils_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_test_utils_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget_win.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	views/widget/native_widget_win_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget.h	View	4 chunks	+15 lines, -6 lines	0 comments	Download
M	views/widget/widget.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages