views/view_unittest.cc - Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/view_unittest.cc

Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: views/view_unittest.cc

===================================================================

--- views/view_unittest.cc (revision 86623)

+++ views/view_unittest.cc (working copy)

@@ -295,7 +295,7 @@

scoped_ptr<Widget> widget(new Widget);

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = gfx::Rect(50, 50, 650, 650);

widget->Init(params);

View* root = widget->GetRootView();

@@ -404,7 +404,7 @@

scoped_ptr<Widget> widget(new Widget());

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = gfx::Rect(50, 50, 650, 650);

widget->Init(params);

View* root = widget->GetRootView();

@@ -935,7 +935,7 @@

// Create a window and add the view as its child.

scoped_ptr<Widget> widget(new Widget);

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = gfx::Rect(0, 0, 100, 100);

widget->Init(params);

View* root = widget->GetRootView();

@@ -1000,7 +1000,7 @@

scoped_ptr<Widget> widget(new Widget);

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = gfx::Rect(0, 0, 100, 100);

widget->Init(params);

View* root = widget->GetRootView();

@@ -1822,7 +1822,7 @@

scoped_ptr<Widget> widget(new Widget);

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = viewport_bounds;

widget->Init(params);

widget->GetRootView()->SetBoundsRect(viewport_bounds);

« no previous file with comments | « views/focus/focus_manager_unittest.cc ('k') | views/widget/native_widget_gtk.h » ('j') | no next file with comments »