views/widget/native_widget_test_utils_win.cc - Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/widget/native_widget_test_utils_win.cc

Issue 7031053: Make Widget ownership a little clearer by expressing it in terms of an enum. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: views/widget/native_widget_test_utils_win.cc

===================================================================

--- views/widget/native_widget_test_utils_win.cc (revision 86623)

+++ views/widget/native_widget_test_utils_win.cc (working copy)

@@ -18,7 +18,7 @@

NativeWidget* CreateNativeWidgetWithContents(View* contents_view) {

Widget* widget = new Widget;

Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.bounds = gfx::Rect(10, 10, 200, 200);

widget->Init(params);

return widget->native_widget();

@@ -27,7 +27,7 @@

NativeWidget* CreateNativeWidgetWithParent(NativeWidget* parent) {

Widget* widget = new Widget;

Widget::InitParams params(Widget::InitParams::TYPE_CONTROL);

- params.delete_on_destroy = false;

+ params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

params.child = false; // Implicitly set to true by ctor with TYPE_CONTROL.

params.parent = parent ? parent->GetWidget()->GetNativeView() : NULL;

params.bounds = gfx::Rect(10, 10, 200, 200);

« no previous file with comments | « views/widget/native_widget_test_utils_gtk.cc ('k') | views/widget/native_widget_win.h » ('j') | no next file with comments »