Make Widget ownership a little clearer by expressing it in terms of an enum.

chrome/browser/ui/views/fullscreen_exit_bubble.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/fullscreen_exit_bubble.h"
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "grit/generated_resources.h"
@@ skipping 115 matching lines @@
   bool got_accelerator = frame->GetAccelerator(IDC_FULLSCREEN, &accelerator);
   DCHECK(got_accelerator);
   view_ = new FullscreenExitView(
       this, UTF16ToWideHack(accelerator.GetShortcutText()));
 
   // Initialize the popup.
   popup_ = new views::Widget;
   views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
   params.transparent = true;
   params.can_activate = false;
-  params.delete_on_destroy = false;
+  params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.parent = frame->GetNativeView();
   params.bounds = GetPopupRect(false);
   popup_->Init(params);
   popup_->SetContentsView(view_);
   popup_->SetOpacity(static_cast<unsigned char>(0xff * kOpacity));
   popup_->Show();  // This does not activate the popup.
 
   // Start the initial delay timer and begin watching the mouse.
   initial_delay_.Start(base::TimeDelta::FromMilliseconds(kInitialDelayMs), this,
                        &FullscreenExitBubble::CheckMousePosition);
   gfx::Point cursor_pos = views::Screen::GetCursorScreenPoint();
   last_mouse_pos_ = cursor_pos;
   views::View::ConvertPointToView(NULL, root_view_, &last_mouse_pos_);
   mouse_position_checker_.Start(
       base::TimeDelta::FromMilliseconds(1000 / kPositionCheckHz), this,
       &FullscreenExitBubble::CheckMousePosition);
 }
 
 FullscreenExitBubble::~FullscreenExitBubble() {
   // This is tricky.  We may be in an ATL message handler stack, in which case
-  // the popup cannot be deleted yet.  We also can't blindly use
-  // set_delete_on_destroy(true) on the popup to delete it when it closes,
-  // because if the user closed the last tab while in fullscreen mode, Windows
-  // has already destroyed the popup HWND by the time we get here, and thus
-  // either the popup will already have been deleted (if we set this in our
-  // constructor) or the popup will never get another OnFinalMessage() call (if
-  // not, as currently).  So instead, we tell the popup to synchronously hide,
-  // and then asynchronously close and delete itself.
+  // the popup cannot be deleted yet.  We also can't set the popup's ownership
+  // model to NATIVE_WIDGET_OWNS_WIDGET because if the user closed the last tab
+  // while in fullscreen mode, Windows has already destroyed the popup HWND by
+  // the time we get here, and thus either the popup will already have been
+  // deleted (if we set this in our constructor) or the popup will never get
+  // another OnFinalMessage() call (if not, as currently).  So instead, we tell
+  // the popup to synchronously hide, and then asynchronously close and delete
+  // itself.
   popup_->Close();
   MessageLoop::current()->DeleteSoon(FROM_HERE, popup_);
 }
 
 void FullscreenExitBubble::LinkClicked(views::Link* source, int event_flags) {
   delegate_->ExecuteCommand(IDC_FULLSCREEN);
 }
 
 void FullscreenExitBubble::AnimationProgressed(
     const ui::Animation* animation) {
@@ skipping 77 matching lines @@
   }
   // NOTE: don't use the bounds of the root_view_. On linux changing window
   // size is async. Instead we use the size of the screen.
   gfx::Rect screen_bounds = views::Screen::GetMonitorAreaNearestWindow(
       root_view_->GetWidget()->GetNativeView());
   gfx::Point origin(screen_bounds.x() +
                     (screen_bounds.width() - size.width()) / 2,
                     screen_bounds.y());
   return gfx::Rect(origin, size);
 }