Cleanup popup related browser navigation code.

Cleanup popup related browser navigation code.

This cleans up some code and fixes a related chromium-os issue:
* Adds a user_gesture parameter to browser::NavigateParams
* Adds AdjustNavigateParams to BrowserWindow and calls that from browser::NavigateParams to make browser window / view class specific changes
* Eliminates Browser::CreateForPopup in favor of browser::Navigate, unifying code paths for spawning popups (thus fixing chromium-os:10978)

BUG=chromium:78853, chromium-os:10978
TEST=Test opening popup windows with a range of sizes and parameters on all OSs (panels on ChromeOS)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83399

[stevenjb, 2011-04-20 18:51:46]

This is not for R13, so no rush, but I wanted to fix this while I was working on
similar code.

[stevenjb, 2011-04-20 18:52:16]

On 2011/04/20 18:51:46, Steven Bennetts wrote:
> This is not for R13, so no rush, but I wanted to fix this while I was working
on
> similar code.

I meant, this is for R13, not R12, so no rush.

[Ben Goodger (Google), 2011-04-20 19:10:32]

http://codereview.chromium.org/6881073/diff/1020/chrome/browser/ui/browser_na...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/6881073/diff/1020/chrome/browser/ui/browser_na...
chrome/browser/ui/browser_navigator.cc:379:
source_browser->window()->AdjustNavigateParams(params);
I worry that this connection couples the BrowserWindow too closely to the
navigator. Can we restate this more generally? ... 

e.g. 

if (source_browser && source_browser->window())
  disposition =
source_browser->window()->GetDispositionForPopupBounds(params->bounds ...)

[stevenjb, 2011-04-20 20:43:40]

PTAL

http://codereview.chromium.org/6881073/diff/1020/chrome/browser/ui/browser_na...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/6881073/diff/1020/chrome/browser/ui/browser_na...
chrome/browser/ui/browser_navigator.cc:379:
source_browser->window()->AdjustNavigateParams(params);
Sounds reasonable to me. Done.

On 2011/04/20 19:10:32, Ben Goodger wrote:
> I worry that this connection couples the BrowserWindow too closely to the
> navigator. Can we restate this more generally? ... 
> 
> e.g. 
> 
> if (source_browser && source_browser->window())
>   disposition =
> source_browser->window()->GetDispositionForPopupBounds(params->bounds ...)
>

[Ben Goodger (Google), 2011-04-20 20:50:40]

LGTM from a browser navigator/integration pov.

[jennb, 2011-04-21 17:22:40]

LGTM

[stevenjb, 2011-04-28 19:07:11]

Avi, I've merged this with the popup blocker changes you made, can you take a
look? Thanks.

[Avi (use Gerrit), 2011-04-28 19:27:10]

Yay for unification! LGTM

http://codereview.chromium.org/6881073/diff/8001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_host.cc (right):

http://codereview.chromium.org/6881073/diff/8001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_host.cc:600: // (If none is found, NULL
argument to NavigateParams is valid).
Period inside parens.