chrome/browser/ui/views/frame/browser_view.cc - Issue 6881073: Cleanup popup related browser navigation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 6881073: Cleanup popup related browser navigation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and merge with avi's popup block changes. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 6a7d46d03286f0ca78be68ed7d32cbd1b4110f74..dfc2798390f1d410c8c669c58d2b0a5e5ef83bc9 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1220,6 +1220,11 @@ gfx::Rect BrowserView::GetInstantBounds() {

return contents_->GetPreviewBounds();

}

+WindowOpenDisposition BrowserView::GetDispositionForPopupBounds(

+ const gfx::Rect& bounds) {

+ return NEW_POPUP;

#if defined(OS_CHROMEOS)

void BrowserView::ShowKeyboardOverlay(gfx::NativeWindow owning_window) {

KeyboardOverlayDialogView::ShowDialog(owning_window, this);