Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3367)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 6881073: Cleanup popup related browser navigation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and merge with avi's popup block changes. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 2802afba79a8711333c1045f194f4cb1ac06eeec..ec2f091db7957fbb3b773051fbbabb7d9860221d 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -9,6 +9,7 @@
#include "chrome/common/content_settings_types.h"
#include "content/browser/tab_contents/navigation_entry.h"
#include "ui/gfx/native_widget_types.h"
+#include "webkit/glue/window_open_disposition.h"
class Browser;
class BrowserWindowTesting;
@@ -326,6 +327,10 @@ class BrowserWindow {
// placed at.
virtual gfx::Rect GetInstantBounds() = 0;
+ // Return the correct disposition for a popup window based on |bounds|.
+ virtual WindowOpenDisposition GetDispositionForPopupBounds(
+ const gfx::Rect& bounds) = 0;
+
#if defined(OS_CHROMEOS)
// Shows the keyboard overlay dialog box.
virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) = 0;

Powered by Google App Engine
This is Rietveld 408576698