Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 06507e0dee90c1684b74705d74a2a735680d0c42..372c4d37ebc5f3e2826241cf94680511b705852c 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -350,10 +350,11 @@ bool PrerenderManager::MaybeUsePreloadedPage(TabContents* tc, const GURL& url) {
// TODO(evan): use directionality of title.
// http://code.google.com/p/chromium/issues/detail?id=27094
- string16 title = pc->title();
- if (!title.empty()) {
- tc->UpdateTitle(rvh, pc->page_id(), title,
- WebKit::WebTextDirectionLeftToRight);
+ string16 title_str = pc->title();
+ if (!title_str.empty()) {
+ base::i18n::String16WithDirection title(title_str,
+ base::i18n::LEFT_TO_RIGHT);
+ tc->UpdateTitle(rvh, pc->page_id(), title);
}
GURL icon_url = pc->icon_url();

Powered by Google App Engine
This is Rietveld 408576698