Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: chrome/browser/tab_contents/web_contents_unittest.cc

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/web_contents_unittest.cc
diff --git a/chrome/browser/tab_contents/web_contents_unittest.cc b/chrome/browser/tab_contents/web_contents_unittest.cc
index f026b0c7b9f66f27054d25768af5c23151bc523b..7b21143b65fcf662f37492ef884153e119283fa8 100644
--- a/chrome/browser/tab_contents/web_contents_unittest.cc
+++ b/chrome/browser/tab_contents/web_contents_unittest.cc
@@ -237,8 +237,10 @@ TEST_F(TabContentsTest, UpdateTitle) {
NavigationController::LoadCommittedDetails details;
controller().RendererDidNavigate(params, 0, &details);
- contents()->UpdateTitle(rvh(), 0, ASCIIToUTF16(" Lots O' Whitespace\n"),
- WebKit::WebTextDirectionLeftToRight);
+ base::i18n::String16WithDirection new_title(
+ ASCIIToUTF16(" Lots O' Whitespace\n"),
+ base::i18n::LEFT_TO_RIGHT);
+ contents()->UpdateTitle(rvh(), 0, new_title);
EXPECT_EQ(ASCIIToUTF16("Lots O' Whitespace"), contents()->GetTitle());
}

Powered by Google App Engine
This is Rietveld 408576698