Add and use a base::i18n::StringWithDirection for carrying titles.

base/i18n/rtl.h

Index: base/i18n/rtl.h
diff --git a/base/i18n/rtl.h b/base/i18n/rtl.h
index a75ed4f967bcd20bd42048994bf5114d51825917..82d13b3fcd557ddad4d667e42ecbadbfbe832d28 100644
--- a/base/i18n/rtl.h
+++ b/base/i18n/rtl.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -31,6 +31,23 @@ enum TextDirection {
   LEFT_TO_RIGHT,
 };
 
+// A string along with the text direction it should be displayed in.
+// Conceptually this is a struct; we just use 'class' to make it easier for
+// others to forward-declare us with 'class String16WithDirection'.
+class String16WithDirection {
+public:

[darin (slow to review), 2011/04/21 20:16:22]

nit: public and private labels should be indented by 1 space right?

+  String16WithDirection() : direction_(UNKNOWN_DIRECTION) { }
+  String16WithDirection(const string16& str, TextDirection dir)
+      : string_(str), direction_(dir) { }
+
+  const string16& string() const { return string_; }
+  TextDirection direction() const { return direction_; }
+
+private:
+  string16 string_;
+  TextDirection direction_;
+};
+
 // Get the locale that the currently running process has been configured to use.
 // The return value is of the form language[-country] (e.g., en-US) where the
 // language is the 2 or 3 letter code from ISO-639.