Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index 2d325955b08a55e0def1a008a9d39526650c6c65..f4fa03342b0b02ea5196ba5050a302317abe364d 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/prerender/prerender_contents.h"
+#include "base/i18n/rtl.h"
#include "base/process_util.h"
#include "base/task.h"
#include "base/utf_string_conversions.h"
@@ -266,16 +267,16 @@ void PrerenderContents::DidNavigate(
url_ = params.url;
}
-void PrerenderContents::UpdateTitle(RenderViewHost* render_view_host,
- int32 page_id,
- const string16& title,
- WebKit::WebTextDirection title_direction) {
- if (title.empty())
+void PrerenderContents::UpdateTitle(
+ RenderViewHost* render_view_host,
+ int32 page_id,
+ const base::i18n::String16WithDirection& title) {
+ if (title.string().empty())
return;
// TODO(evan): use directionality of title.
// http://code.google.com/p/chromium/issues/detail?id=27094
- title_ = title;
+ title_ = title.string();
page_id_ = page_id;
}

Powered by Google App Engine
This is Rietveld 408576698