Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6794056: Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation fra... (Closed)

Created:
9 years, 8 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kkania, amit, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation framework could miss a browsercrash during shutdown on POSIX (on Windows there iscrash_service.exe that should catch all crashes).This change makes the automation framework avoid losinginformation about the browser process' exit status(CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout(which on POSIX never reported the process has been signaled).Finally, it makes the automation framework use WaitForExitCodeWithTimeoutinstead of WaitForSingleProcess. This way we can get the exit statusinformation in an accurate and cross-platform way.To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them.I've tested this change locally on Mac with a UI test that SIGKILLs the browser.Before this change the test passed (it shouldn't), and after this changethe test failed with an information that the browser has not exited cleanly.BUG=56644 Review URL: http://codereview.chromium.org/6689014 TBR=phajdan.jr@chromium.org [----------] 1 test from MultipartResponseUITest [ RUN ] MultipartResponseUITest.SingleVisit [3538:3538:0405/104633:11326126024137:ERROR:process_util_posix.cc(108)] Received signal 11 base::debug::StackTrace::StackTrace() [0xcd194a] base::(anonymous namespace)::StackDumpSignalHandler() [0xcb0e5a] 0x2b835e391100 AutomationProxy::GetBrowserWindowCount() [0x2055e86] ProxyLauncher::IsBrowserRunning() [0xc3f1a2] ProxyLauncher::QuitBrowser() [0xc454b3] ProxyLauncher::CloseBrowserAndServer() [0xc472d6] UITestBase::TearDown() [0xc50d54] UITest::TearDown() [0xc51260] testing::TestInfo::Run() [0xe8de78] testing::TestCase::Run() [0xe8df35] testing::internal::UnitTestImpl::RunAllTests() [0xe8f6e7] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0xe804d5] testing::internal::HandleExceptionsInMethodIfSupported<>() [0xe8ba92] testing::UnitTest::Run() [0xe8badb] base::TestSuite::Run() [0x212c26d] main [0xc48e41] 0x2b835e37d1c4 0x42fec9 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -102 lines) Patch
M base/process_util.h View 2 chunks +5 lines, -2 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +17 lines, -5 lines 0 comments Download
M base/process_util_win.cc View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux_uitest.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/unload_uitest.cc View 4 chunks +17 lines, -18 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/automation/proxy_launcher.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 5 chunks +28 lines, -35 lines 0 comments Download
M chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/test/out_of_proc_test_runner.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 11 chunks +50 lines, -13 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
9 years, 8 months ago (2011-04-05 18:05:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698