Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: chrome/test/automation/proxy_launcher.h

Issue 6794056: Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation fra... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util_unittest.cc ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/proxy_launcher.h
===================================================================
--- chrome/test/automation/proxy_launcher.h (revision 80485)
+++ chrome/test/automation/proxy_launcher.h (working copy)
@@ -122,10 +122,13 @@
// window or if the browser process died by itself.
bool IsBrowserRunning();
+ // Returns true when timeout_ms milliseconds have elapsed.
+ // Returns false if the browser process died while waiting.
+ bool CrashAwareSleep(int timeout_ms);
+
// Wait for the browser process to shut down on its own (i.e. as a result of
- // some action that your test has taken). If it has exited within |timeout|,
- // puts the exit code in |exit_code| and returns true.
- bool WaitForBrowserProcessToQuit(int timeout, int* exit_code);
+ // some action that your test has taken).
+ bool WaitForBrowserProcessToQuit(int timeout);
AutomationProxy* automation() const;
« no previous file with comments | « chrome/common/service_process_util_unittest.cc ('k') | chrome/test/automation/proxy_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698