Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome_frame/test/perf/chrome_frame_perftest.cc

Issue 6794056: Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation fra... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ui_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/perf/chrome_frame_perftest.cc
===================================================================
--- chrome_frame/test/perf/chrome_frame_perftest.cc (revision 80485)
+++ chrome_frame/test/perf/chrome_frame_perftest.cc (working copy)
@@ -1358,8 +1358,7 @@
bool RunSingleTestOutOfProc(const std::string& test_name) {
FilePath path;
- if (!PathService::Get(base::DIR_EXE, &path))
- return false;
+ PathService::Get(base::DIR_EXE, &path);
path = path.Append(L"chrome_frame_tests.exe");
CommandLine cmd_line(path);
@@ -1385,8 +1384,6 @@
base::KillProcess(process_handle, -1, true);
}
- base::CloseProcessHandle(process_handle);
-
return exit_code == 0;
}
« no previous file with comments | « chrome/test/ui/ui_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698