chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc - Issue 6794056: Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation fra...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

Issue 6794056: Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation fra... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

===================================================================

--- chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc (revision 80485)

+++ chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc (working copy)

@@ -54,9 +54,6 @@

ASSERT_TRUE(automation()->WaitForAppModalDialog());

ASSERT_TRUE(automation()->ClickAppModalDialogButton(

ui::MessageBoxFlags::DIALOGBUTTON_OK));

- int exit_code = -1;

- ASSERT_TRUE(launcher_->WaitForBrowserProcessToQuit(

- TestTimeouts::wait_for_terminate_timeout_ms(), &exit_code));

- EXPECT_EQ(0, exit_code); // Expect a clean shutdown.

+ ASSERT_TRUE(WaitForBrowserProcessToQuit(

+ TestTimeouts::wait_for_terminate_timeout_ms()));

}

« no previous file with comments | « chrome/test/automation/proxy_launcher.cc ('k') | chrome/test/out_of_proc_test_runner.cc » ('j') | no next file with comments »