Change text of DNS prefetch option to Network prediction option.

Change text of DNS prefetch option to Network prediction option.

The "DNS Prefetch" option currently controls DNS prefetching, TCP preconnection, 
and prerendering of pages. This modifies the text string to replace
this, and changes variable names to reflect it.

The underlying preference name remains the same so settings are not
lost. However, I changed the policy name to make name changes
consistent. If this does not migrate well, I will retain the old
policy name.   

BUG=77783
TEST=Existing tests, make sure text is correct in browser.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80768

[cbentzel, 2011-04-05 18:36:49]

I changed the text of DNS prefetch to better reflect it's current behavior.

The string used in the user prefs remains the same so old settings work
correctly. 

Danno: It looks like I can safely change the policy_template.json name field as
long as the id remains consistent. Please let me know if that assumption is
wrong. Also, do you localize policy text at all?

[cbentzel, 2011-04-05 18:41:53]

Actually, I still need to fix localized_error.cc. The rest of the CL is still
OK, and is mainly renames.

[jar (doing other things), 2011-04-05 18:52:32]

Please check with folks that are more savvy about the structure of the UI
changes (and what goes where in various files).  You can see some guestimates of
an answer to your question below.... but the experts will have the real answers.

http://codereview.chromium.org/6793045/diff/2001/chrome/renderer/localized_er...
File chrome/renderer/localized_error.cc (right):

http://codereview.chromium.org/6793045/diff/2001/chrome/renderer/localized_er...
chrome/renderer/localized_error.cc:485: if (options.suggestions &
SUGGEST_DNS_CONFIG) {
I suspect that all appearances of dns (upper and lower case) need to be
migrated.

I believe the contents of this section relate to the "learn more" link available
just above where the current DNS setting is toggled.

You really need to talk to the UI guys to make sure your changes are correct
(and refer to proper string names).

[Nirnimesh, 2011-04-05 19:11:02]

http://codereview.chromium.org/6793045/diff/3001/chrome/test/functional/enter...
File chrome/test/functional/enterprise.py (right):

http://codereview.chromium.org/6793045/diff/3001/chrome/test/functional/enter...
chrome/test/functional/enterprise.py:142: (pyauto.kNetworkPredictionEnabled,
True, False),
This test depends on enterprise policy settings. Did that string change too?
In that case you need to update chrome/test/data/enterprise/chrome-add.reg too

[cbentzel, 2011-04-05 20:30:29]

http://codereview.chromium.org/6793045/diff/3001/chrome/test/functional/enter...
File chrome/test/functional/enterprise.py (right):

http://codereview.chromium.org/6793045/diff/3001/chrome/test/functional/enter...
chrome/test/functional/enterprise.py:142: (pyauto.kNetworkPredictionEnabled,
True, False),
On 2011/04/05 19:11:02, Nirnimesh wrote:
> This test depends on enterprise policy settings. Did that string change too?
> In that case you need to update chrome/test/data/enterprise/chrome-add.reg too

Sorry, I did not change chrome-add.reg.

Is that file treated as canonical data? I thought policy_templates.json only
needed to be changed? I intended to only change internal names and
documentation, but not change actual user settings or registry settings.

[cbentzel, 2011-04-05 20:33:43]

More reviewers:

danno+Nirnimesh: I want to make sure that the renames for policy only impact
internal variable names and documentation, and will not invalidate local
settings. Please let me know if I violated this. I retain the same text key for
the prefs data so that case looks covered [and I manually tested this] but I'm
less clear about the policy impact changes.

jar+phajdan.jr: net_pref_observer and predictor_api.cc

mmenke: localized_error.cc and generated_resources.grd

[mmenke, 2011-04-05 20:50:20]

http://codereview.chromium.org/6793045/diff/3003/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:5883: <message
name="IDS_ERRORPAGES_SUGGESTION_FIREWALL_CONFIG" desc="When a web page fails to
load, in some cases we suggest reconfiguring the firewall.">
Is there a reason you moved this?  The suggestions here had been in the order
they appear both on the error page itself and in localized_error.cc.

http://codereview.chromium.org/6793045/diff/3003/chrome/renderer/localized_er...
File chrome/renderer/localized_error.cc (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/renderer/localized_er...
chrome/renderer/localized_error.cc:503:
error_strings->Set("suggestionsDisableDNSPrefetch",
You should change this string to match.  The other place it appears is in
chrome/renderer/resources/neterror.html.

[danno, 2011-04-05 20:53:02]

Changing the policy name is probably not a good idea, see my comments for more
details.

http://codereview.chromium.org/6793045/diff/3003/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.json:215: 'name': 'NetworkPredictionEnabled',
Changing the policy name also changes the name of the window policy and the
registry keys used to active the policy, as well as the keys used to identify
the policy on Mac and Linux, so this is probably not a good idea for already
published policies. If you really want to change the name, you can introduce a
new policy and deprecate the old one, but you'd still have to support the
deprecated one for a while (see ProxyMode as an example).

http://codereview.chromium.org/6793045/diff/3003/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.json:222: 'desc': '''Enables network
prediction in <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> and prevents
users from changing this setting.
These string get (or at least should get) the localization treatment by the
localization team. We haven't released a version of translated templates yet,
but as long as your original text is in here it should get translated when we
get that far.

[cbentzel, 2011-04-05 21:00:45]

Thanks Danno. I'll revert back to the old name.

http://codereview.chromium.org/6793045/diff/3003/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:5883: <message
name="IDS_ERRORPAGES_SUGGESTION_FIREWALL_CONFIG" desc="When a web page fails to
load, in some cases we suggest reconfiguring the firewall.">
On 2011/04/05 20:50:20, Matt Menke wrote:
> Is there a reason you moved this?  The suggestions here had been in the order
> they appear both on the error page itself and in localized_error.cc.

For some reason I thought these were alphabetized. Done.

http://codereview.chromium.org/6793045/diff/3003/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.json:215: 'name': 'NetworkPredictionEnabled',
On 2011/04/05 20:53:03, danno wrote:
> Changing the policy name also changes the name of the window policy and the
> registry keys used to active the policy, as well as the keys used to identify
> the policy on Mac and Linux, so this is probably not a good idea for already
> published policies. If you really want to change the name, you can introduce a
> new policy and deprecate the old one, but you'd still have to support the
> deprecated one for a while (see ProxyMode as an example).

Thanks a ton for this comment - I will retain the old name. I was hoping that
keeping a consistent id would be sufficient, but I was wrong.

http://codereview.chromium.org/6793045/diff/3003/chrome/renderer/localized_er...
File chrome/renderer/localized_error.cc (right):

http://codereview.chromium.org/6793045/diff/3003/chrome/renderer/localized_er...
chrome/renderer/localized_error.cc:503:
error_strings->Set("suggestionsDisableDNSPrefetch",
On 2011/04/05 20:50:20, Matt Menke wrote:
> You should change this string to match.  The other place it appears is in
> chrome/renderer/resources/neterror.html.

Done.

[mmenke, 2011-04-05 21:05:17]

Changes in localized_errors.cc and generated_resources.grd LGTM.

[cbentzel, 2011-04-05 21:59:12]

On 2011/04/05 21:05:17, Matt Menke wrote:
> Changes in localized_errors.cc and generated_resources.grd LGTM.

The latest patchset reverts back to the old policy name. It's more than a little
unfortunate that we have two different naming schemes for the same behavior
throughout the code, but it doesn't seem like there's an easy way to prevent
that without breaking configurations in the wild.

Nirnimesh: Do the functional tests expect the registry key and the preference
value to be the same? Is there a good way for me to test this locally? Is there
a trybot I can exercise?

[Nirnimesh, 2011-04-05 22:49:05]

> 
> Nirnimesh: Do the functional tests expect the registry key and the preference
> value to be the same?

No

> Is there a good way for me to test this locally?

Yes. On windows (this test is windows only) build the 'pyautolib' target, then
python chrome/test/functional/enterprise.py

> Is there
> a trybot I can exercise?

No

[Nirnimesh, 2011-04-05 22:49:23]

File I commented on LGTM

[cbentzel, 2011-04-06 19:17:55]

Latest patchset is up to date with head and fixes copyright, otherwise the same.

I also ran some of the pyautotests on my windows box to validate that they are
working correctly.

[wtc, 2011-05-02 18:27:14]

http://codereview.chromium.org/6793045/diff/10003/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6793045/diff/10003/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5894: and deselect &quot;<ph
name="NO_PREFETCH_DESCRIPTION">&lt;span
jscontent="noNetworkPredictionTitle"&gt;&lt;/span&gt;<ex>Predict network actions
to improve page load performance</ex></ph>.&quot;
Just a nit: the placeholder name "NO_PREFETCH_DESCRIPTION"
should also be changed to "NO_NETWORK_PREDICTION_DESCRIPTION"?