Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7932)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
index 71b83c6436e421df73f1161b9a43beea59ac9a89..931a7e06a6357aadeab77c0dc7a9934acca8bcaa 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
@@ -18,7 +18,7 @@ namespace {
class MockView : public PermissionBubbleView {
public:
MockView() : shown_(false), can_accept_updates_(true), delegate_(NULL) {}
- virtual ~MockView() {}
+ ~MockView() override {}
void Clear() {
shown_ = false;
@@ -29,30 +29,21 @@ class MockView : public PermissionBubbleView {
}
// PermissionBubbleView:
- virtual void SetDelegate(Delegate* delegate) override {
- delegate_ = delegate;
- }
+ void SetDelegate(Delegate* delegate) override { delegate_ = delegate; }
- virtual void Show(
- const std::vector<PermissionBubbleRequest*>& requests,
- const std::vector<bool>& accept_state,
- bool customization_state_) override {
+ void Show(const std::vector<PermissionBubbleRequest*>& requests,
+ const std::vector<bool>& accept_state,
+ bool customization_state_) override {
shown_ = true;
permission_requests_ = requests;
permission_states_ = accept_state;
}
- virtual void Hide() override {
- shown_ = false;
- }
+ void Hide() override { shown_ = false; }
- virtual bool CanAcceptRequestUpdate() override {
- return can_accept_updates_;
- }
+ bool CanAcceptRequestUpdate() override { return can_accept_updates_; }
- virtual bool IsVisible() override {
- return shown_;
- }
+ bool IsVisible() override { return shown_; }
bool shown_;
bool can_accept_updates_;

Powered by Google App Engine
This is Rietveld 408576698