Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index 2a663e7a0bb2b2479a3a73d01f7e144b18bf9d28..fbc5833fe185c55a95a481fd77d7a30a00a6cb01 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -22,32 +22,22 @@ class CancelledRequest : public PermissionBubbleRequest {
message_fragment_(cancelled->GetMessageTextFragment()),
user_gesture_(cancelled->HasUserGesture()),
hostname_(cancelled->GetRequestingHostname()) {}
- virtual ~CancelledRequest() {}
+ ~CancelledRequest() override {}
- virtual int GetIconID() const override {
- return icon_;
- }
- virtual base::string16 GetMessageText() const override {
- return message_text_;
- }
- virtual base::string16 GetMessageTextFragment() const override {
+ int GetIconID() const override { return icon_; }
+ base::string16 GetMessageText() const override { return message_text_; }
+ base::string16 GetMessageTextFragment() const override {
return message_fragment_;
}
- virtual bool HasUserGesture() const override {
- return user_gesture_;
- }
- virtual GURL GetRequestingHostname() const override {
- return hostname_;
- }
+ bool HasUserGesture() const override { return user_gesture_; }
+ GURL GetRequestingHostname() const override { return hostname_; }
// These are all no-ops since the placeholder is non-forwarding.
- virtual void PermissionGranted() override {}
- virtual void PermissionDenied() override {}
- virtual void Cancelled() override {}
+ void PermissionGranted() override {}
+ void PermissionDenied() override {}
+ void Cancelled() override {}
- virtual void RequestFinished() override {
- delete this;
- }
+ void RequestFinished() override { delete this; }
private:
int icon_;

Powered by Google App Engine
This is Rietveld 408576698