chrome/browser/ui/website_settings/permission_menu_model.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc ('k') | chrome/browser/ui/website_settings/website_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_menu_model.h

diff --git a/chrome/browser/ui/website_settings/permission_menu_model.h b/chrome/browser/ui/website_settings/permission_menu_model.h

index 4f1080915456e5508ca803a26ed5ff9883563617..527070758a030a2331443f65f8e6ad3ac5527e9a 100644

--- a/chrome/browser/ui/website_settings/permission_menu_model.h

+++ b/chrome/browser/ui/website_settings/permission_menu_model.h

@@ -28,15 +28,14 @@ class PermissionMenuModel : public ui::SimpleMenuModel,

PermissionMenuModel(const GURL& url,

ContentSetting setting,

const ChangeCallback& callback);

- virtual ~PermissionMenuModel();

+ ~PermissionMenuModel() override;

// Overridden from ui::SimpleMenuModel::Delegate:

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

private:

// The permission info represented by the menu model.