Standardize usage of virtual/override/final in chrome/browser/ui/

chrome/browser/ui/android/tab_model/tab_model.h

Index: chrome/browser/ui/android/tab_model/tab_model.h
diff --git a/chrome/browser/ui/android/tab_model/tab_model.h b/chrome/browser/ui/android/tab_model/tab_model.h
index f9fd8ef12fc07d51056ee5fb05a39b77fa7a4092..f6678d52346cdca70bffc598b1d81263bee52b68 100644
--- a/chrome/browser/ui/android/tab_model/tab_model.h
+++ b/chrome/browser/ui/android/tab_model/tab_model.h
@@ -56,7 +56,7 @@ class TabModel : public content::NotificationObserver {
 
  protected:
   explicit TabModel(Profile* profile);
-  virtual ~TabModel();
+  ~TabModel() override;

[msw, 2014/10/21 19:36:11]

Why does this seem to operate contrary to the Google C++ style guide?
"Make your destructor virtual if necessary. If your class has virtual methods,
its destructor should be virtual."
Is the actual "virtual" keyword no longer necessary to mark the destructor
virtual if the "override" keyword is used?

[dcheng, 2014/10/21 20:14:53]

From http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance
Explicitly annotate overrides of virtual functions or virtual destructors with
an override or (less frequently) final specifier.

You're not the only one that's expressed surprise at this, and I raised this
issue on chromium-dev. However, the wording seems unambiguous and the general
consensus seems to be that we should follow the Google style.

 
   // Instructs the TabModel to broadcast a notification that all tabs are now
   // loaded from storage.
@@ -66,9 +66,9 @@ class TabModel : public content::NotificationObserver {
 
  private:
   // Determines how TabModel will interact with the profile.
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) override;
+  void Observe(int type,

[msw, 2014/10/21 19:36:11]

I guess this is implementing the following policy? "For clarity, use exactly one
of override, final, or virtual when declaring an override."

[dcheng, 2014/10/21 20:14:53]

Yep.

+               const content::NotificationSource& source,
+               const content::NotificationDetails& details) override;
 
   // The profile associated with this TabModel.
   Profile* profile_;