chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

index fe1e9d8e5cee443eac850c7b28dfd3ae51505044..4042a0b8a36f90167e1653dd67a3750bf9bc8c2b 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

@@ -37,7 +37,7 @@ class ExtensionKeybindingRegistryCocoa

gfx::NativeWindow window,

ExtensionFilter extension_filter,

Delegate* delegate);

- virtual ~ExtensionKeybindingRegistryCocoa();

+ ~ExtensionKeybindingRegistryCocoa() override;

static void set_shortcut_handling_suspended(bool suspended) {

shortcut_handling_suspended_ = suspended;

@@ -54,12 +54,10 @@ class ExtensionKeybindingRegistryCocoa

protected:

// Overridden from ExtensionKeybindingRegistry:

- virtual void AddExtensionKeybinding(

- const extensions::Extension* extension,

- const std::string& command_name) override;

- virtual void RemoveExtensionKeybindingImpl(

- const ui::Accelerator& accelerator,

- const std::string& command_name) override;

+ void AddExtensionKeybinding(const extensions::Extension* extension,

+ const std::string& command_name) override;

+ void RemoveExtensionKeybindingImpl(const ui::Accelerator& accelerator,

+ const std::string& command_name) override;

private:

// Keeps track of whether shortcut handling is currently suspended. Shortcuts