Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7431)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
index ef156753b1a2b5f7a7af330e3aaf81d61072cbcf..117114741eb717d81aed0522eb734bafbcacffa0 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
@@ -73,14 +73,13 @@ class ExtensionPopupContainer : public ExtensionViewMac::Container {
: controller_(controller) {
}
- virtual void OnExtensionSizeChanged(
- ExtensionViewMac* view,
- const gfx::Size& new_size) override {
+ void OnExtensionSizeChanged(ExtensionViewMac* view,
+ const gfx::Size& new_size) override {
[controller_ onSizeChanged:
NSMakeSize(new_size.width(), new_size.height())];
}
- virtual void OnExtensionViewDidShow(ExtensionViewMac* view) override {
+ void OnExtensionViewDidShow(ExtensionViewMac* view) override {
[controller_ onViewDidShow];
}
@@ -99,7 +98,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
content::DevToolsAgentHost::AddAgentStateCallback(devtools_callback_);
}
- virtual ~DevtoolsNotificationBridge() {
+ ~DevtoolsNotificationBridge() override {
content::DevToolsAgentHost::RemoveAgentStateCallback(devtools_callback_);
}
@@ -120,10 +119,9 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
}
}
- virtual void Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
switch (type) {
case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {
if (content::Details<extensions::ExtensionViewHost>(

Powered by Google App Engine
This is Rietveld 408576698