chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h ('k') | chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 637eb393fae4738fa4c8cbc110495a76a9a2900e..d0981d2493db498456d6927f35c763fee644efd5 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -73,10 +73,9 @@ class ExtensionLoadedNotificationObserver

private:

// NotificationObserver implementation. Tells the controller to start showing

// its window on the main thread when the extension has finished loading.

- virtual void Observe(

- int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override {

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override {

if (type == extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED) {

const Extension* extension =

content::Details<const Extension>(details).ptr();