Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.h
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.h b/chrome/browser/ui/website_settings/permission_bubble_manager.h
index c80b3f73c84b5af2f59ecf4ea0b3b529053ecdb9..2783bdf9af7b530df1f11446afc76afd4876b595 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.h
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.h
@@ -33,7 +33,7 @@ class PermissionBubbleManager
// Return the flag-driven enabled state of permissions bubbles.
static bool Enabled();
- virtual ~PermissionBubbleManager();
+ ~PermissionBubbleManager() override;
// Adds a new request to the permission bubble. Ownership of the request
// remains with the caller. The caller must arrange for the request to
@@ -55,7 +55,7 @@ class PermissionBubbleManager
// Sets the active view for the permission bubble. If this is NULL, it
// means any existing permission bubble can no longer be shown. Does not
// take ownership of the view.
- virtual void SetView(PermissionBubbleView* view) override;
+ void SetView(PermissionBubbleView* view) override;
private:
friend class PermissionBubbleManagerTest;
@@ -65,22 +65,22 @@ class PermissionBubbleManager
explicit PermissionBubbleManager(content::WebContents* web_contents);
// WebContentsObserver:
- virtual void DocumentOnLoadCompletedInMainFrame() override;
- virtual void DocumentLoadedInFrame(
+ void DocumentOnLoadCompletedInMainFrame() override;
+ void DocumentLoadedInFrame(
content::RenderFrameHost* render_frame_host) override;
// If a page on which permissions requests are pending is navigated,
// they will be finalized as if canceled by the user.
- virtual void NavigationEntryCommitted(
+ void NavigationEntryCommitted(
const content::LoadCommittedDetails& details) override;
- virtual void WebContentsDestroyed() override;
+ void WebContentsDestroyed() override;
// PermissionBubbleView::Delegate:
- virtual void ToggleAccept(int request_index, bool new_value) override;
- virtual void SetCustomizationMode() override;
- virtual void Accept() override;
- virtual void Deny() override;
- virtual void Closing() override;
+ void ToggleAccept(int request_index, bool new_value) override;
+ void SetCustomizationMode() override;
+ void Accept() override;
+ void Deny() override;
+ void Closing() override;
// Posts a task which will allow the bubble to become visible if it is needed.
void ScheduleShowBubble();

Powered by Google App Engine
This is Rietveld 408576698