chrome/browser/ui/extensions/extension_installed_bubble.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/extensions/extension_install_ui_default.cc ('k') | chrome/browser/ui/external_protocol_dialog_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_installed_bubble.h

diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.h b/chrome/browser/ui/extensions/extension_installed_bubble.h

index ab160f66c4823f92e5699f99b5216cafd687c96e..08bbf95f16c76b35d7f1be17ab941df200894192 100644

--- a/chrome/browser/ui/extensions/extension_installed_bubble.h

+++ b/chrome/browser/ui/extensions/extension_installed_bubble.h

@@ -57,7 +57,7 @@ class ExtensionInstalledBubble : public content::NotificationObserver,

Browser *browser,

const SkBitmap& icon);

- virtual ~ExtensionInstalledBubble();

+ ~ExtensionInstalledBubble() override;

const extensions::Extension* extension() const { return extension_; }

Browser* browser() { return browser_; }

@@ -73,15 +73,14 @@ class ExtensionInstalledBubble : public content::NotificationObserver,

void ShowInternal();

// content::NotificationObserver:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// extensions::ExtensionRegistryObserver:

- virtual void OnExtensionLoaded(

- content::BrowserContext* browser_context,

- const extensions::Extension* extension) override;

- virtual void OnExtensionUnloaded(

+ void OnExtensionLoaded(content::BrowserContext* browser_context,

+ const extensions::Extension* extension) override;

+ void OnExtensionUnloaded(

content::BrowserContext* browser_context,

const extensions::Extension* extension,

extensions::UnloadedExtensionInfo::Reason reason) override;