chrome/browser/ui/extensions/extension_install_ui_default.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_install_ui_default.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/extensions/extension_install_ui_default.h ('k') | chrome/browser/ui/extensions/extension_installed_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_install_ui_default.cc

diff --git a/chrome/browser/ui/extensions/extension_install_ui_default.cc b/chrome/browser/ui/extensions/extension_install_ui_default.cc

index 8a7a95229224fe7017174e253e230bba81559d24..fca3f02c3530a227dd2459814daba3a7e92de7c6 100644

--- a/chrome/browser/ui/extensions/extension_install_ui_default.cc

+++ b/chrome/browser/ui/extensions/extension_install_ui_default.cc

@@ -80,13 +80,13 @@ class ErrorInfoBarDelegate : public ConfirmInfoBarDelegate {

private:

explicit ErrorInfoBarDelegate(const extensions::CrxInstallerError& error);

- virtual ~ErrorInfoBarDelegate();

+ ~ErrorInfoBarDelegate() override;

// ConfirmInfoBarDelegate:

- virtual base::string16 GetMessageText() const override;

- virtual int GetButtons() const override;

- virtual base::string16 GetLinkText() const override;

- virtual bool LinkClicked(WindowOpenDisposition disposition) override;

+ base::string16 GetMessageText() const override;

+ int GetButtons() const override;

+ base::string16 GetLinkText() const override;

+ bool LinkClicked(WindowOpenDisposition disposition) override;

extensions::CrxInstallerError error_;