chrome/browser/ui/external_protocol_dialog_delegate.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/external_protocol_dialog_delegate.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/extensions/extension_installed_bubble.h ('k') | chrome/browser/ui/fast_unload_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/external_protocol_dialog_delegate.h

diff --git a/chrome/browser/ui/external_protocol_dialog_delegate.h b/chrome/browser/ui/external_protocol_dialog_delegate.h

index 12879ca4d5f4426cabd7253bde11149e0f2c2309..5ddb6b14207c1801f5292beb4c2e3d1f8a3029d3 100644

--- a/chrome/browser/ui/external_protocol_dialog_delegate.h

+++ b/chrome/browser/ui/external_protocol_dialog_delegate.h

@@ -18,16 +18,16 @@ class ExternalProtocolDialogDelegate : public ProtocolDialogDelegate {

explicit ExternalProtocolDialogDelegate(const GURL& url,

int render_process_host_id,

int tab_contents_id);

- virtual ~ExternalProtocolDialogDelegate();

+ ~ExternalProtocolDialogDelegate() override;

const base::string16& program_name() const { return program_name_; }

- virtual void DoAccept(const GURL& url, bool dont_block) const override;

- virtual void DoCancel(const GURL& url, bool dont_block) const override;

+ void DoAccept(const GURL& url, bool dont_block) const override;

+ void DoCancel(const GURL& url, bool dont_block) const override;

- virtual base::string16 GetMessageText() const override;

- virtual base::string16 GetCheckboxText() const override;

- virtual base::string16 GetTitleText() const override;

+ base::string16 GetMessageText() const override;

+ base::string16 GetCheckboxText() const override;

+ base::string16 GetTitleText() const override;

private:

int render_process_host_id_;