Issue 6676015: Coverity: Pass values by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676015: Coverity: Pass values by reference. (Closed)

Created:
9 years, 9 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Coverity: Pass values by reference. CID=8402,8494,8641,8716,8717,8740,9100 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77788

Patch Set 1 #

Total comments: 1

Patch Set 2 : Win/Mac fix. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
M	chrome/browser/extensions/image_loading_tracker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/memory_details.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/memory_details_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/memory_details_mac.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/memory_details_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_info.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/url_info.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_store.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 9 months ago (2011-03-11 01:53:19 UTC) #2

LGTM

http://codereview.chromium.org/6676015/diff/1/chrome/browser/memory_details.h
File chrome/browser/memory_details.h (right):

http://codereview.chromium.org/6676015/diff/1/chrome/browser/memory_details.h...
chrome/browser/memory_details.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
nit: bump copyright date, here and others

Expand Messages | Collapse Messages