Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/password_manager/password_store.h

Issue 6676015: Coverity: Pass values by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win/Mac fix. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_info.cc ('k') | chrome/browser/password_manager/password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store.h
diff --git a/chrome/browser/password_manager/password_store.h b/chrome/browser/password_manager/password_store.h
index 1ac6f8bf9f17eec7f122b3d97beb8988e76a698a..32f9c81e4ca96bdc76c806a0e139e7af07c5c1fd 100644
--- a/chrome/browser/password_manager/password_store.h
+++ b/chrome/browser/password_manager/password_store.h
@@ -140,7 +140,7 @@ class PasswordStore : public base::RefCountedThreadSafe<PasswordStore> {
// Notifies the consumer that a Get*Logins() request is complete.
virtual void NotifyConsumer(
GetLoginsRequest* request,
- const std::vector<webkit_glue::PasswordForm*> forms);
+ const std::vector<webkit_glue::PasswordForm*>& forms);
private:
// Called by NotifyConsumer, but runs in the consumer's thread. Will not
@@ -148,7 +148,7 @@ class PasswordStore : public base::RefCountedThreadSafe<PasswordStore> {
// that PasswordStoreConsumer doesn't have to be reference counted (we assume
// consumers will cancel their requests before they are destroyed).
void NotifyConsumerImpl(PasswordStoreConsumer* consumer, int handle,
- const std::vector<webkit_glue::PasswordForm*> forms);
+ const std::vector<webkit_glue::PasswordForm*>& forms);
// Returns a new request handle tracked in pending_requests_.
int GetNewRequestHandle();
« no previous file with comments | « chrome/browser/net/url_info.cc ('k') | chrome/browser/password_manager/password_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698