Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/browser/ui/gtk/location_bar_view_gtk.h

Issue 6676015: Coverity: Pass values by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win/Mac fix. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_ 5 #ifndef CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_
6 #define CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_ 6 #define CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 221
222 void set_preview_enabled(bool preview_enabled) { 222 void set_preview_enabled(bool preview_enabled) {
223 preview_enabled_ = preview_enabled; 223 preview_enabled_ = preview_enabled;
224 } 224 }
225 225
226 bool IsVisible() { return GTK_WIDGET_VISIBLE(widget()); } 226 bool IsVisible() { return GTK_WIDGET_VISIBLE(widget()); }
227 227
228 // Called to notify the PageAction that it should determine whether to be 228 // Called to notify the PageAction that it should determine whether to be
229 // visible or hidden. |contents| is the TabContents that is active, |url| 229 // visible or hidden. |contents| is the TabContents that is active, |url|
230 // is the current page URL. 230 // is the current page URL.
231 void UpdateVisibility(TabContents* contents, GURL url); 231 void UpdateVisibility(TabContents* contents, const GURL& url);
232 232
233 // A callback from ImageLoadingTracker for when the image has loaded. 233 // A callback from ImageLoadingTracker for when the image has loaded.
234 virtual void OnImageLoaded( 234 virtual void OnImageLoaded(
235 SkBitmap* image, const ExtensionResource& resource, int index); 235 SkBitmap* image, const ExtensionResource& resource, int index);
236 236
237 // Simulate left mouse click on the page action button. 237 // Simulate left mouse click on the page action button.
238 void TestActivatePageAction(); 238 void TestActivatePageAction();
239 239
240 // Overridden from ExtensionContextMenuModel::PopupDelegate: 240 // Overridden from ExtensionContextMenuModel::PopupDelegate:
241 virtual void InspectPopup(ExtensionAction* action); 241 virtual void InspectPopup(ExtensionAction* action);
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 // Indicate if |tab_to_search_hint_| should be shown. 446 // Indicate if |tab_to_search_hint_| should be shown.
447 bool show_keyword_hint_; 447 bool show_keyword_hint_;
448 448
449 // The last search keyword that was shown via the |tab_to_search_box_|. 449 // The last search keyword that was shown via the |tab_to_search_box_|.
450 string16 last_keyword_; 450 string16 last_keyword_;
451 451
452 DISALLOW_COPY_AND_ASSIGN(LocationBarViewGtk); 452 DISALLOW_COPY_AND_ASSIGN(LocationBarViewGtk);
453 }; 453 };
454 454
455 #endif // CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_ 455 #endif // CHROME_BROWSER_UI_GTK_LOCATION_BAR_VIEW_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store.cc ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698