chrome/browser/memory_details_mac.cc - Issue 6676015: Coverity: Pass values by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_mac.cc

Issue 6676015: Coverity: Pass values by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win/Mac fix. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory_details_mac.cc

diff --git a/chrome/browser/memory_details_mac.cc b/chrome/browser/memory_details_mac.cc

index 8b33825e9de5a9de24fde4013c9a8222b4b31963..c03c8c96ac2c42c3b994c2924cb6497d57e5918e 100644

--- a/chrome/browser/memory_details_mac.cc

+++ b/chrome/browser/memory_details_mac.cc

@@ -84,7 +84,7 @@ ProcessData* MemoryDetails::ChromeBrowser() {

}

void MemoryDetails::CollectProcessData(

- std::vector<ProcessMemoryInformation> child_info) {

+ const std::vector<ProcessMemoryInformation>& child_info) {

// This must be run on the file thread to avoid jank (|ProcessInfoSnapshot|

// runs /bin/ps, which isn't instantaneous).

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

« no previous file with comments | « chrome/browser/memory_details_linux.cc ('k') | chrome/browser/memory_details_win.cc » ('j') | no next file with comments »