Issue 6674006: Coverity Fixlets.

Issue 6674006: Coverity Fixlets. (Closed)

Created:
9 years, 9 months ago by Sheridan Rawlins

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Coverity Fixlets: CHECKED_RETURNs CID=15628,1968,3877 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77754

Patch Set 4 : reverted 6283,3909 #

Patch Set 5 : check against OK. #

Total comments: 2

Patch Set 6 : nit squash. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	chrome/browser/sessions/session_backend.cc	View	1 2 3 4 5	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/net/predictor_queue.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/renderer/net/predictor_queue.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/pepper_platform_context_3d_impl.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/6674006/diff/3008/chrome/browser/bookmarks/bookmark_index.cc File chrome/browser/bookmarks/bookmark_index.cc (right): http://codereview.chromium.org/6674006/diff/3008/chrome/browser/bookmarks/bookmark_index.cc#newcode132 chrome/browser/bookmarks/bookmark_index.cc:132: int typed_count = 0; Sorry, not familiar with this ...

9 years, 9 months ago (2011-03-11 01:09:35 UTC) #1

Sheridan Rawlins

ok, reverted 6283,3909 for this patch. http://codereview.chromium.org/6674006/diff/3008/chrome/browser/bookmarks/bookmark_index.cc File chrome/browser/bookmarks/bookmark_index.cc (right): http://codereview.chromium.org/6674006/diff/3008/chrome/browser/bookmarks/bookmark_index.cc#newcode132 chrome/browser/bookmarks/bookmark_index.cc:132: int typed_count = ...

9 years, 9 months ago (2011-03-11 01:39:49 UTC) #2

Lei Zhang

LGTM with nit below: http://codereview.chromium.org/6674006/diff/2013/chrome/browser/sessions/session_backend.cc File chrome/browser/sessions/session_backend.cc (right): http://codereview.chromium.org/6674006/diff/2013/chrome/browser/sessions/session_backend.cc#newcode369 chrome/browser/sessions/session_backend.cc:369: if(file->Open(path, base::PLATFORM_FILE_CREATE_ALWAYS | nit: "if(" ...

9 years, 9 months ago (2011-03-11 01:45:11 UTC) #3

Sheridan Rawlins

9 years, 9 months ago (2011-03-11 01:49:59 UTC) #4

http://codereview.chromium.org/6674006/diff/2013/chrome/browser/sessions/sess...
File chrome/browser/sessions/session_backend.cc (right):

http://codereview.chromium.org/6674006/diff/2013/chrome/browser/sessions/sess...
chrome/browser/sessions/session_backend.cc:369: if(file->Open(path,
base::PLATFORM_FILE_CREATE_ALWAYS |
On 2011/03/11 01:45:11, Lei Zhang wrote:
> nit: "if(" -> "if ("

Done.

Expand Messages | Collapse Messages