Coverity Fixlets.

chrome/browser/debugger/debugger_remote_service.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains implementations of the DebuggerRemoteService methods,
 // defines DebuggerRemoteService and DebuggerRemoteServiceCommand constants.
 
 #include "chrome/browser/debugger/debugger_remote_service.h"
 
 #include "base/json/json_reader.h"
@@ skipping 277 matching lines @@
   }
   DevToolsClientHost* client_host =
       manager->GetDevToolsClientHostFor(tab_contents->render_view_host());
   if (client_host == NULL) {
     // tab_uid is not being debugged (Attach has not been invoked)
     response->SetInteger(kResultKey, RESULT_ILLEGAL_TAB_STATE);
     return true;
   }
   std::string v8_command;
   DictionaryValue* v8_command_value;
-  content->GetDictionary(kDataKey, &v8_command_value);
+  if (!content->GetDictionary(kDataKey, &v8_command_value))
+    return true;

[Lei Zhang, 2011/03/11 01:09:35]

I have no idea if this is right. I would leave this change out of the CL, make a
separate CL for it, and have whoever wrote this code review it.

[Sheridan Rawlins, 2011/03/11 01:39:49]

reverted

   base::JSONWriter::Write(v8_command_value, false, &v8_command);
   manager->ForwardToDevToolsAgent(
       client_host, DevToolsAgentMsg_DebuggerCommand(v8_command));
   // Do not send the response right now, as the JSON will be received from
   // the V8 debugger asynchronously.
   return false;
 }
 
 // Sends the immediate "evaluate Javascript" command to the V8 debugger.
 // The evaluation result is not sent back to the client as this command
@@ skipping 18 matching lines @@
     // No RenderViewHost
     response->SetInteger(kResultKey, RESULT_UNKNOWN_TAB);
     return true;
   }
   std::string javascript;
   content->GetString(kDataKey, &javascript);
   render_view_host->ExecuteJavascriptInWebFrame(string16(),
                                                 UTF8ToUTF16(javascript));
   return false;
 }