Coverity Fixlets.

chrome/renderer/net/predictor_queue.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See header file for description of DnsQueue class
 
 #include "chrome/renderer/net/predictor_queue.h"
 
 #include "base/logging.h"
 #include "base/metrics/stats_counters.h"
 
 DnsQueue::DnsQueue(BufferSize size)
     : buffer_(new char[size + 2]),
       buffer_size_(size + 1),
       buffer_sentinel_(size + 1),
       size_(0) {
   CHECK(0 < static_cast<BufferSize>(size + 3));  // Avoid overflow worries.
   buffer_[buffer_sentinel_] = '\0';  // Guard byte to help reading data.
   readable_ = writeable_ = 0;  // Buffer starts empty.
 }
 
 DnsQueue::~DnsQueue(void) {
 }
 
+void DnsQueue::Clear() {
+  size_ = 0;
+  readable_ = writeable_;
+  DCHECK(Validate());

[Lei Zhang, 2011/03/11 01:09:35]

never put calls with side effects inside a DCHECK. Validate() won't run in
release mode.

[Sheridan Rawlins, 2011/03/11 01:39:49]

Validate is used in DCHECK elsewhere in the code (no side effects - it's just a
big conditional).

+}
+
 // Push takes an unterminated string plus its length.
 // The string must not contain a null terminator.
 // Exactly length chars are written, or nothing is written.
 // Returns true for success, false there was no room to push.
 DnsQueue::PushResult DnsQueue::Push(const char* source,
                                     const size_t unsigned_length) {
   BufferSize length = static_cast<BufferSize>(unsigned_length);
   if (0 > length+1)  // Avoid overflows in conversion to signed.
     return OVERFLOW_PUSH;
 
@@ skipping 102 matching lines @@
 }
 
 bool DnsQueue::Validate() {
   return (readable_ >= 0) &&
           readable_ < buffer_sentinel_ &&
           writeable_ >= 0 &&
           writeable_ < buffer_sentinel_ &&
           '\0' == buffer_[buffer_sentinel_] &&
           ((0 == size_) == (readable_ == writeable_));
 }