Coverity Fixlets.

chrome/browser/bookmarks/bookmark_index.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_index.h"
 
 #include <algorithm>
 #include <iterator>
 #include <list>
 
@@ skipping 111 matching lines @@
             &NodeTypedCountPairSortFunc);
 }
 
 void BookmarkIndex::ExtractBookmarkNodePairs(
     history::URLDatabase* url_db,
     const Match& match,
     NodeTypedCountPairs* node_typed_counts) const {
 
   for (NodeSet::const_iterator i = match.nodes_begin();
        i != match.nodes_end(); ++i) {
-    history::URLRow url;
-    if (url_db)
-      url_db->GetRowForURL((*i)->GetURL(), &url);
-    NodeTypedCountPair pair(*i, url.typed_count());
+    int typed_count = 0;

[Lei Zhang, 2011/03/11 01:09:35]

Sorry, not familiar with this code either. See note about v8.

[Sheridan Rawlins, 2011/03/11 01:39:49]

reverted

+    if (url_db) {
+      history::URLRow url;
+      if (url_db->GetRowForURL((*i)->GetURL(), &url))
+        typed_count = url.typed_count();
+    }
+    NodeTypedCountPair pair(*i, typed_count);
     node_typed_counts->push_back(pair);
   }
 }
 
 void BookmarkIndex::AddMatchToResults(
     const BookmarkNode* node,
     QueryParser* parser,
     const std::vector<QueryNode*>& query_nodes,
     std::vector<bookmark_utils::TitleMatch>* results) {
   bookmark_utils::TitleMatch title_match;
@@ skipping 116 matching lines @@
   Index::iterator i = index_.find(term);
   if (i == index_.end()) {
     // We can get here if the node has the same term more than once. For
     // example, a bookmark with the title 'foo foo' would end up here.
     return;
   }
   i->second.erase(node);
   if (i->second.empty())
     index_.erase(i);
 }