Issue 6670119: VM initialization refactoring.

Issue 6670119: VM initialization refactoring. (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

VM initialization refactoring. This patch introduces global once per-process initialization and moves the OS and CPU setup there. This makes CPU features isolate-independent. Committed: http://code.google.com/p/v8/source/detail?r=7462

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+273 lines, -223 lines)			Patch
M	src/arm/cpu-arm.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/cpu.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	3 chunks	+64 lines, -24 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	49 chunks	+73 lines, -70 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	19 chunks	+19 lines, -21 lines	1 comment	Download
M	src/ia32/codegen-ia32.cc	View	14 chunks	+14 lines, -14 lines	0 comments	Download
M	src/ia32/cpu-ia32.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	src/isolate.cc	View	5 chunks	+0 lines, -12 lines	0 comments	Download
M	src/platform.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/v8.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/v8.cc	View	4 chunks	+33 lines, -9 lines	1 comment	Download
M	src/x64/cpu-x64.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View	8 chunks	+16 lines, -16 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-03-31 13:48:21 UTC) #2

LGTM!

http://codereview.chromium.org/6670119/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (left):

http://codereview.chromium.org/6670119/diff/1/src/ia32/code-stubs-ia32.cc#old...
src/ia32/code-stubs-ia32.cc:2830:
masm->isolate()->cpu_features()->IsEnabled(SSE2)) {
Auch. Good catch!

http://codereview.chromium.org/6670119/diff/1/src/v8.cc
File src/v8.cc (right):

http://codereview.chromium.org/6670119/diff/1/src/v8.cc#newcode211
src/v8.cc:211: // Peephole optimization might interfere with deoptimization.
This is fine. Maybe we should file a bug report on getting rid of peephole
optimizations. Now that crankshaft is the default we should just rip it out.

Expand Messages | Collapse Messages