Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/isolate.h

Issue 6670119: VM initialization refactoring. (Closed)
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 03a4866f4572febf0dde2af6194257bb609a94a5..a9962c3f9fd636d45ddcfb1e51890a727dd95b7e 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -242,6 +242,7 @@ class HashMap;
#ifdef ENABLE_DEBUGGER_SUPPORT
#define ISOLATE_DEBUGGER_INIT_LIST(V) \
+ V(uint64_t, enabled_cpu_features, 0) \
V(v8::Debug::EventCallback, debug_event_callback, NULL) \
V(DebuggerAgent*, debugger_agent_instance, NULL)
#else
@@ -708,10 +709,6 @@ class Isolate {
Bootstrapper* bootstrapper() { return bootstrapper_; }
Counters* counters() { return counters_; }
- // TODO(isolates): Having CPU features per isolate is probably too
- // flexible. We only really need to have the set of currently
- // enabled features for asserts in DEBUG builds.
- CpuFeatures* cpu_features() { return cpu_features_; }
CodeRange* code_range() { return code_range_; }
RuntimeProfiler* runtime_profiler() { return runtime_profiler_; }
CompilationCache* compilation_cache() { return compilation_cache_; }
@@ -1029,7 +1026,6 @@ class Isolate {
RuntimeProfiler* runtime_profiler_;
CompilationCache* compilation_cache_;
Counters* counters_;
- CpuFeatures* cpu_features_;
CodeRange* code_range_;
Mutex* break_access_;
Heap heap_;

Powered by Google App Engine
This is Rietveld 408576698