Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 6626025: CHROMIUM: video: tegra: Run pll_d at 252mhz for HDMI 640x480 (Closed)

Created:
9 years, 9 months ago by Stephen Warren
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Mandeep Singh Baines
Visibility:
Public.

Description

CHROMIUM: video: tegra: Run pll_d at 252mhz for HDMI 640x480 Using a pll_d clock rate of 216MHz yields a 24MHz pixel clock instead of 25.2MHz. This is just under a 5% error. Instead, use a 252MHz pll_d rate, which generates 25.2MHz exactly. This makes it more likely that monitors will sync to the emitted signal. This also fixes HDMI audio issues, since the CTS/N tables are now based on the actual pixel clock rate, not merely the intended pixel clock rate. Tested with a 12MHz pll_m rate on Seaboard, all of 32/44.1/48KHz audio, all video modes supported by the Tegra dc HDMI driver, and a Dell U2410 dislay. Signed-off-by: Stephen Warren <swarren@nvidia.com>; BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M drivers/video/tegra/dc/dc.c View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Stephen Warren
This series of patches implements audio-over-HDMI support: http://codereview.chromium.org/6625021 http://codereview.chromium.org/6623022 http://codereview.chromium.org/6626025 http://codereview.chromium.org/6632011 http://codereview.chromium.org/6624031 http://codereview.chromium.org/6624032 http://codereview.chromium.org/6623023 http://codereview.chromium.org/6625022 ...
9 years, 9 months ago (2011-03-04 21:27:20 UTC) #1
Olof Johansson
9 years, 9 months ago (2011-03-07 03:42:16 UTC) #2
Thanks, applied.

Powered by Google App Engine
This is Rietveld 408576698