Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 6624031: CHROMIUM: ASoC: tegra: Implement SPDIF CPU DAI (Closed)

Created:
9 years, 9 months ago by Stephen Warren
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Mandeep Singh Baines, Olof Johansson
Visibility:
Public.

Description

CHROMIUM: ASoC: tegra: Implement SPDIF CPU DAI This is a minimal driver for the Tegra SPDIF controller. In hardware, the SPDIF signal is always routed to any active HDMI display controllers, and may also be routed to external pins on Tegra. This minimal driver is targetted purely at HDMI usage, but may work for the SPDIF pins too, given the correct pinmux settings. Signed-off-by: Stephen Warren <swarren@nvidia.com>; BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+864 lines, -0 lines) Patch
M sound/soc/tegra/Kconfig View 2 chunks +11 lines, -0 lines 0 comments Download
M sound/soc/tegra/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
A sound/soc/tegra/tegra_spdif.h View 1 chunk +473 lines, -0 lines 0 comments Download
A sound/soc/tegra/tegra_spdif.c View 1 chunk +378 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Stephen Warren
This series of patches implements audio-over-HDMI support: http://codereview.chromium.org/6625021 http://codereview.chromium.org/6623022 http://codereview.chromium.org/6626025 http://codereview.chromium.org/6632011 http://codereview.chromium.org/6624031 http://codereview.chromium.org/6624032 http://codereview.chromium.org/6623023 http://codereview.chromium.org/6625022 ...
9 years, 9 months ago (2011-03-04 21:27:35 UTC) #1
Olof Johansson
9 years, 9 months ago (2011-03-07 03:41:32 UTC) #2
I'll apply this, but two nitpicks that should be considered when you upstream:

1) new drivers are normally preferred to keep without defaults (i.e. default n).
ARM isn't quite as picky as x86 on this though.

2) the TEGRA_SPDIF_* defines are loong. Since they're driver-local in scope and
name space pollution isn't quite an issue, I would consider abbreviating them a
bit to make the lines shorter.

Powered by Google App Engine
This is Rietveld 408576698