Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 651031: Begin using a list of bailouts instead of a singleton in the fast code generator. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Begin using a list of bailouts instead of a singleton in the fast code generator. A list of bailout descriptions is kept in the CompilationInfo structure that is shared between the primary and secondary code generators. The primary adds a description to the list for each bailout position. Responsibility for binding labels is moved from the primary to the secondary code generator. All the labels still target the start of the secondary code and the compilation state of the primary is still ignored. Move the compilation mode flag to the CompilationInfo. Committed: http://code.google.com/p/v8/source/detail?r=3920

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -92 lines) Patch
M src/arm/codegen-arm.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/arm/codegen-arm.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 5 chunks +21 lines, -14 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 5 chunks +52 lines, -1 line 1 comment Download
M src/fast-codegen.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/fast-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/fast-codegen-ia32.h View 4 chunks +6 lines, -3 lines 1 comment Download
M src/ia32/fast-codegen-ia32.cc View 6 chunks +25 lines, -18 lines 0 comments Download
M src/x64/codegen-x64.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/x64/codegen-x64.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 5 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 10 months ago (2010-02-19 13:51:22 UTC) #1
fschneider
10 years, 10 months ago (2010-02-19 14:47:14 UTC) #2
LGTM with comments addressed.

http://codereview.chromium.org/651031/diff/1/6
File src/compiler.h (right):

http://codereview.chromium.org/651031/diff/1/6#newcode64
src/compiler.h:64: Bailout(Register left, Register right) : left_(left),
right_(right) {}
label_ needs to be initialized here.

http://codereview.chromium.org/651031/diff/1/12
File src/ia32/fast-codegen-ia32.h (right):

http://codereview.chromium.org/651031/diff/1/12#newcode35
src/ia32/fast-codegen-ia32.h:35: #include "list.h"
list.h should be already included from compiler.h, shouldn't it?

Powered by Google App Engine
This is Rietveld 408576698