Issue 6480003: Fix various places which do not check if SetProperty threw an exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6480003: Fix various places which do not check if SetProperty threw an exception. (Closed)

Created:
9 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix various places which do not check if SetProperty threw an exception. Committed: http://code.google.com/p/v8/source/detail?r=6729

Patch Set 2 : Minor improvement #

Total comments: 2

Patch Set 3 : Addressing Mads' comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -106 lines)			Patch
M	src/api.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/bootstrapper.cc	View		11 chunks	+25 lines, -26 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/factory.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/handles.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		16 chunks	+53 lines, -56 lines	0 comments	Download
M	src/top.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/top.cc	View		4 chunks	+10 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6480003/diff/2001/src/factory.cc File src/factory.cc (right): http://codereview.chromium.org/6480003/diff/2001/src/factory.cc#newcode583 src/factory.cc:583: // Currently save as is only invoked from ...

9 years, 10 months ago (2011-02-10 10:26:43 UTC) #2

antonm

9 years, 10 months ago (2011-02-10 14:18:33 UTC) #3

Thanks for review.  Submitting

http://codereview.chromium.org/6480003/diff/2001/src/factory.cc
File src/factory.cc (right):

http://codereview.chromium.org/6480003/diff/2001/src/factory.cc#newcode583
src/factory.cc:583: // Currently save as is only invoked from Genesis.
On 2011/02/10 10:26:43, Mads Ager wrote:
> save as -> safe because it

Done.