Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: src/api.cc

Issue 6480003: Fix various places which do not check if SetProperty threw an exception. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing Mads' comment Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 // --- T e m p l a t e --- 663 // --- T e m p l a t e ---
664 664
665 665
666 static void InitializeTemplate(i::Handle<i::TemplateInfo> that, int type) { 666 static void InitializeTemplate(i::Handle<i::TemplateInfo> that, int type) {
667 that->set_tag(i::Smi::FromInt(type)); 667 that->set_tag(i::Smi::FromInt(type));
668 } 668 }
669 669
670 670
671 void Template::Set(v8::Handle<String> name, v8::Handle<Data> value, 671 void Template::Set(v8::Handle<String> name, v8::Handle<Data> value,
672 v8::PropertyAttribute attribute) { 672 v8::PropertyAttribute attribute) {
673 if (IsDeadCheck("v8::Template::SetProperty()")) return; 673 if (IsDeadCheck("v8::Template::Set()")) return;
674 ENTER_V8; 674 ENTER_V8;
675 HandleScope scope; 675 HandleScope scope;
676 i::Handle<i::Object> list(Utils::OpenHandle(this)->property_list()); 676 i::Handle<i::Object> list(Utils::OpenHandle(this)->property_list());
677 if (list->IsUndefined()) { 677 if (list->IsUndefined()) {
678 list = NeanderArray().value(); 678 list = NeanderArray().value();
679 Utils::OpenHandle(this)->set_property_list(*list); 679 Utils::OpenHandle(this)->set_property_list(*list);
680 } 680 }
681 NeanderArray array(list); 681 NeanderArray array(list);
682 array.add(Utils::OpenHandle(*name)); 682 array.add(Utils::OpenHandle(*name));
683 array.add(Utils::OpenHandle(*value)); 683 array.add(Utils::OpenHandle(*value));
(...skipping 4496 matching lines...) Expand 10 before | Expand all | Expand 10 after
5180 5180
5181 5181
5182 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 5182 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
5183 HandleScopeImplementer* thread_local = 5183 HandleScopeImplementer* thread_local =
5184 reinterpret_cast<HandleScopeImplementer*>(storage); 5184 reinterpret_cast<HandleScopeImplementer*>(storage);
5185 thread_local->IterateThis(v); 5185 thread_local->IterateThis(v);
5186 return storage + ArchiveSpacePerThread(); 5186 return storage + ArchiveSpacePerThread();
5187 } 5187 }
5188 5188
5189 } } // namespace v8::internal 5189 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698