Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: src/handles.h

Issue 6480003: Fix various places which do not check if SetProperty threw an exception. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing Mads' comment Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/factory.cc ('k') | src/handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 216
217 Handle<Object> ForceDeleteProperty(Handle<JSObject> object, 217 Handle<Object> ForceDeleteProperty(Handle<JSObject> object,
218 Handle<Object> key); 218 Handle<Object> key);
219 219
220 Handle<Object> SetLocalPropertyIgnoreAttributes( 220 Handle<Object> SetLocalPropertyIgnoreAttributes(
221 Handle<JSObject> object, 221 Handle<JSObject> object,
222 Handle<String> key, 222 Handle<String> key,
223 Handle<Object> value, 223 Handle<Object> value,
224 PropertyAttributes attributes); 224 PropertyAttributes attributes);
225 225
226 // Used to set local properties on the object we totally control
227 // and which therefore has no accessors and alikes.
228 void SetLocalPropertyNoThrow(Handle<JSObject> object,
229 Handle<String> key,
230 Handle<Object> value,
231 PropertyAttributes attributes = NONE);
232
226 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object, 233 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object,
227 Handle<String> key, 234 Handle<String> key,
228 Handle<Object> value, 235 Handle<Object> value,
229 PropertyAttributes attributes); 236 PropertyAttributes attributes);
230 237
231 Handle<Object> SetElement(Handle<JSObject> object, 238 Handle<Object> SetElement(Handle<JSObject> object,
232 uint32_t index, 239 uint32_t index,
233 Handle<Object> value); 240 Handle<Object> value);
234 241
235 Handle<Object> SetOwnElement(Handle<JSObject> object, 242 Handle<Object> SetOwnElement(Handle<JSObject> object,
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 private: 384 private:
378 bool has_been_transformed_; // Tells whether the object has been transformed. 385 bool has_been_transformed_; // Tells whether the object has been transformed.
379 int unused_property_fields_; // Captures the unused number of field. 386 int unused_property_fields_; // Captures the unused number of field.
380 Handle<JSObject> object_; // The object being optimized. 387 Handle<JSObject> object_; // The object being optimized.
381 }; 388 };
382 389
383 390
384 } } // namespace v8::internal 391 } } // namespace v8::internal
385 392
386 #endif // V8_HANDLES_H_ 393 #endif // V8_HANDLES_H_
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698