Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/handles.cc

Issue 6480003: Fix various places which do not check if SetProperty threw an exception. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing Mads' comment Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 Handle<Object> SetLocalPropertyIgnoreAttributes( 283 Handle<Object> SetLocalPropertyIgnoreAttributes(
284 Handle<JSObject> object, 284 Handle<JSObject> object,
285 Handle<String> key, 285 Handle<String> key,
286 Handle<Object> value, 286 Handle<Object> value,
287 PropertyAttributes attributes) { 287 PropertyAttributes attributes) {
288 CALL_HEAP_FUNCTION(object-> 288 CALL_HEAP_FUNCTION(object->
289 SetLocalPropertyIgnoreAttributes(*key, *value, attributes), Object); 289 SetLocalPropertyIgnoreAttributes(*key, *value, attributes), Object);
290 } 290 }
291 291
292 292
293 void SetLocalPropertyNoThrow(Handle<JSObject> object,
294 Handle<String> key,
295 Handle<Object> value,
296 PropertyAttributes attributes) {
297 ASSERT(!Top::has_pending_exception());
298 CHECK(!SetLocalPropertyIgnoreAttributes(
299 object, key, value, attributes).is_null());
300 CHECK(!Top::has_pending_exception());
301 }
302
303
293 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object, 304 Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object,
294 Handle<String> key, 305 Handle<String> key,
295 Handle<Object> value, 306 Handle<Object> value,
296 PropertyAttributes attributes) { 307 PropertyAttributes attributes) {
297 CALL_HEAP_FUNCTION(object->SetPropertyWithInterceptor(*key, 308 CALL_HEAP_FUNCTION(object->SetPropertyWithInterceptor(*key,
298 *value, 309 *value,
299 attributes), 310 attributes),
300 Object); 311 Object);
301 } 312 }
302 313
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 903
893 OptimizedObjectForAddingMultipleProperties:: 904 OptimizedObjectForAddingMultipleProperties::
894 ~OptimizedObjectForAddingMultipleProperties() { 905 ~OptimizedObjectForAddingMultipleProperties() {
895 // Reoptimize the object to allow fast property access. 906 // Reoptimize the object to allow fast property access.
896 if (has_been_transformed_) { 907 if (has_been_transformed_) {
897 TransformToFastProperties(object_, unused_property_fields_); 908 TransformToFastProperties(object_, unused_property_fields_);
898 } 909 }
899 } 910 }
900 911
901 } } // namespace v8::internal 912 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698