Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/common/child_process_host.h

Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove Nico's changes that I patched in for testing. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/child_process_host.h
diff --git a/chrome/common/child_process_host.h b/chrome/common/child_process_host.h
index c8223468961ab01d9d710105a178d8c4ddfdfc1f..08f585edecfde651c228d3b7ba09c4ab6ad53407 100644
--- a/chrome/common/child_process_host.h
+++ b/chrome/common/child_process_host.h
@@ -58,7 +58,7 @@ class ChildProcessHost : public IPC::Channel::Listener,
#endif // defined(OS_WIN)
// IPC::Message::Sender implementation.
- bool Send(IPC::Message* message);
+ virtual bool Send(IPC::Message* message);
protected:
ChildProcessHost();
@@ -80,9 +80,9 @@ class ChildProcessHost : public IPC::Channel::Listener,
virtual void InstanceCreated();
// IPC::Channel::Listener implementation:
- virtual bool OnMessageReceived(const IPC::Message& msg) { return false; }
Nico 2011/01/27 03:55:17 these two. i will stop repeating this question.
- virtual void OnChannelConnected(int32 peer_pid) { }
- virtual void OnChannelError() { }
+ virtual bool OnMessageReceived(const IPC::Message& msg);
+ virtual void OnChannelConnected(int32 peer_pid);
+ virtual void OnChannelError();
bool opening_channel() { return opening_channel_; }
const std::string& channel_id() { return channel_id_; }
@@ -91,9 +91,9 @@ class ChildProcessHost : public IPC::Channel::Listener,
// Called when the child process goes away.
virtual void OnChildDied();
// Notifies the derived class that we told the child process to kill itself.
- virtual void ShutdownStarted() { }
+ virtual void ShutdownStarted();
// Subclasses can implement specific notification methods.
- virtual void Notify(NotificationType type) { }
+ virtual void Notify(NotificationType type);
private:
// By using an internal class as the IPC::Channel::Listener, we can intercept

Powered by Google App Engine
This is Rietveld 408576698